diff options
author | SiCong Li <sicong.li@arm.com> | 2020-08-10 19:57:46 +0100 |
---|---|---|
committer | SiCong Li <sicong.li@arm.com> | 2020-08-11 08:32:09 +0000 |
commit | 03d8a8991c6d87f227ed149ca653e897ed47dfc0 (patch) | |
tree | ab80baf7e979d395f293a7621b5b74d1d012ccde /data | |
parent | 996c777eea8acb8ce816552e77050dbf388f62be (diff) | |
download | ComputeLibrary-03d8a8991c6d87f227ed149ca653e897ed47dfc0.tar.gz |
COMPMID-3339: Patch1: Fix incorrect select casting in im2col nhwc kernels
* Put an additional cast for correctly handling scalar cases
According to opencl specs, logical operators, when performed on
scalar types, always return int regardless of the type of the scalar.
Thus if we were to use the results of a scalar logical op on the
method select, it would be incorrect for any types of width different
than 4 (the width of int)
A concrete example would be that if the VECTOR_SIZE is 1 (scalar case),
and DATA_TYPE is half/f16 (width < 4), then the result type of the ||
op would be int instead of short, which it's supposed to be, and this
would result in the ambiguous function call error for select.
Signed-off-by: SiCong Li <sicong.li@arm.com>
Change-Id: Ibc4985f707f667116668c43b9f9bf39dda789528
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/3698
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Diffstat (limited to 'data')
0 files changed, 0 insertions, 0 deletions