diff options
author | Gunes Bayir <gunes.bayir@arm.com> | 2023-07-12 14:50:56 +0100 |
---|---|---|
committer | Gunes Bayir <gunes.bayir@arm.com> | 2023-07-12 15:23:55 +0000 |
commit | 3c776066a0195f2e99d3503f8b058e468d53b884 (patch) | |
tree | f91268d28eed0a3446330385185898f6d6aa17f6 /compute_kernel_writer/src/ITile.h | |
parent | 945b8da90cea5ccacc0294e58131f73f39137367 (diff) | |
download | ComputeLibrary-3c776066a0195f2e99d3503f8b058e468d53b884.tar.gz |
Rename ITileOperand and introduce vector/scalar interfaces in CKW
Partially Resolves: COMPMID-5788
This patch
- renames ITileOperand to TileOperand, which seems to be a more intuitive name for the prospective users of Compute Kernel Writer
- provides IScalarAccess and IVectorAccess interfaces to be used by Tile classes. It replaces the current IScalarTile and IVectorTile, and forms a more intuitive inheritance hierarchy where each subclass "is a" member of the parent class semantically.
Signed-off-by: Gunes Bayir <gunes.bayir@arm.com>
Change-Id: I2b5253b0595e63f8ff3047c608d593b3b364634d
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/9910
Reviewed-by: Jakub Sujak <jakub.sujak@arm.com>
Reviewed-by: Viet-Hoa Do <viet-hoa.do@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Benchmark: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Diffstat (limited to 'compute_kernel_writer/src/ITile.h')
-rw-r--r-- | compute_kernel_writer/src/ITile.h | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/compute_kernel_writer/src/ITile.h b/compute_kernel_writer/src/ITile.h index c036907561..bed4996607 100644 --- a/compute_kernel_writer/src/ITile.h +++ b/compute_kernel_writer/src/ITile.h @@ -92,12 +92,12 @@ protected: std::string _basename{ "" }; // Tile name }; -/** Tile base class to store scalar variables. +/** Interface to provide support for scalar access for a Tile. */ -class IScalarTile : public ITile +class IScalarAccess { public: - virtual ~IScalarTile() = default; + virtual ~IScalarAccess() = default; /** Method to get the scalar variable from a tile as a string * @param[in] row Tile row. If out-of-bound, the row is clamped to the nearest valid edge @@ -108,12 +108,12 @@ public: virtual TileVariable scalar(int32_t row, int32_t col) const = 0; }; -/** Tile base class to store vector variables. It derives from IScalarTile since we can still access the scalar variable +/** Interface to provide support for vector access for a tile. */ -class IVectorTile : public IScalarTile +class IVectorAccess { public: - virtual ~IVectorTile() = default; + virtual ~IVectorAccess() = default; /** Method to get the vector variable from a tile. * The user can query the list of supported vector lengths through the supported_vector_lengths() method. @@ -124,11 +124,11 @@ public: */ virtual TileVariable vector(int32_t row) const = 0; - /** Method to get a sub-vector variable. The length of the sub-vector must be supported by the derived IVectorTile class + /** Method to get a sub-vector variable. The length of the sub-vector must be supported by the derived IVectorAccess class * * @param[in] row Tile row. If out-of-bound, the row is clamped to the nearest valid edge - * @param[in] col_start Tile starting column to get the sub-vector. If out-of-bound, the derived IVectorTile class may throw an assert. - * @param[in] width The width of the sub-vector. The width must be supported by the derived IVectorTile class and the last element must be in-bound. + * @param[in] col_start Tile starting column to get the sub-vector. If out-of-bound, the derived IVectorAccess class may throw an assert. + * @param[in] width The width of the sub-vector. The width must be supported by the derived IVectorAccess class and the last element must be in-bound. * * @return the vector variable as a @ref TileVariable */ |