diff options
| author | Michele Di Giorgio <michele.digiorgio@arm.com> | 2019-09-23 16:49:49 +0100 |
|---|---|---|
| committer | Michele Di Giorgio <michele.digiorgio@arm.com> | 2019-09-30 16:45:51 +0000 |
| commit | 9637b2e4fc33b2264aa5586dd6b2ed1045db5075 (patch) | |
| tree | a22d4dd2ff18f86a2da2920151002415b80fefca /arm_compute/runtime | |
| parent | cecb0a75a9de0a12d30f8fabbe16a656c722afa1 (diff) | |
| download | ComputeLibrary-9637b2e4fc33b2264aa5586dd6b2ed1045db5075.tar.gz | |
COMPMID-2671: Change ArgMinMax NEON/CL output type to Signed32
Change-Id: I718f3884928271c5b0afb259d5bfe9df284f18e6
Signed-off-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-on: https://review.mlplatform.org/c/1995
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Diffstat (limited to 'arm_compute/runtime')
| -rw-r--r-- | arm_compute/runtime/CL/functions/CLArgMinMaxLayer.h | 14 | ||||
| -rw-r--r-- | arm_compute/runtime/NEON/functions/NEArgMinMaxLayer.h | 13 |
2 files changed, 19 insertions, 8 deletions
diff --git a/arm_compute/runtime/CL/functions/CLArgMinMaxLayer.h b/arm_compute/runtime/CL/functions/CLArgMinMaxLayer.h index b3a85948a8..2384ebcd37 100644 --- a/arm_compute/runtime/CL/functions/CLArgMinMaxLayer.h +++ b/arm_compute/runtime/CL/functions/CLArgMinMaxLayer.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018 ARM Limited. + * Copyright (c) 2018-2019 ARM Limited. * * SPDX-License-Identifier: MIT * @@ -32,7 +32,13 @@ namespace arm_compute { class ICLTensor; -/** Function to calculate the index of the minimum or maximum values in a tensor based on an axis. */ +/** Function to calculate the index of the minimum or maximum values in a + * tensor based on an axis. + * + * @note The indices are computed in unsigned 32-bit (U32). It is the user's + * responsibility to check that the results do not overflow in case the + * output data type is set to signed 32-bit integer (S32). + */ class CLArgMinMaxLayer : public ICLSimpleFunction { public: @@ -40,7 +46,7 @@ public: * * @param[in] input Input source tensor. Data types supported: F16/F32. * @param[in] axis Axis to find max/min index. - * @param[out] output Output source tensor. Data types supported: U32. + * @param[out] output Output source tensor. Data types supported: U32/S32. * @param[in] op Operation to perform: min or max */ void configure(const ICLTensor *input, int axis, ICLTensor *output, const ReductionOperation &op); @@ -48,7 +54,7 @@ public: * * @param[in] input Input source tensor info. Data types supported: F16/F32. * @param[in] axis Axis to find max/min index. - * @param[in] output Output source tensor info. Data types supported: U32. + * @param[in] output Output source tensor info. Data types supported: U32/S32. * @param[in] op Operation to perform: min or max * * @return a status diff --git a/arm_compute/runtime/NEON/functions/NEArgMinMaxLayer.h b/arm_compute/runtime/NEON/functions/NEArgMinMaxLayer.h index 55b39e45ec..85bf7d92c9 100644 --- a/arm_compute/runtime/NEON/functions/NEArgMinMaxLayer.h +++ b/arm_compute/runtime/NEON/functions/NEArgMinMaxLayer.h @@ -32,14 +32,19 @@ namespace arm_compute { -class IsTensor; +class ITensor; -/** Function to calculate the index of the minimum or maximum values in a tensor based on an axis. +/** Function to calculate the index of the minimum or maximum values in a + * tensor based on an axis. + * * This function calls the following NEON kernels: * * -# @ref NEReductionOperationKernel * -# @ref NEFillBorderKernel * + * @note The indices are computed in unsigned 32-bit (U32). It is the user's + * responsibility to check that the results do not overflow in case the + * output data type is set to signed 32-bit integer (S32). */ class NEArgMinMaxLayer : public IFunction { @@ -50,7 +55,7 @@ public: * * @param[in] input Input source tensor. Data types supported: QASYMM8/S32/F16/F32. * @param[in] axis Axis to find max/min index. - * @param[out] output Output source tensor. Data types supported: U32. + * @param[out] output Output source tensor. Data types supported: U32/S32. * @param[in] op Operation to perform: min or max */ void configure(ITensor *input, int axis, ITensor *output, const ReductionOperation &op); @@ -58,7 +63,7 @@ public: * * @param[in] input Input source tensor info. Data types supported: QASYMM8/S32/F16/F32. * @param[in] axis Axis to find max/min index. - * @param[in] output Output source tensor info. Data types supported: U32. + * @param[in] output Output source tensor info. Data types supported: U32/S32. * @param[in] op Operation to perform: min or max * * @return a status |