diff options
| author | Georgios Pinitas <georgios.pinitas@arm.com> | 2020-07-29 08:19:24 +0100 |
|---|---|---|
| committer | Michele Di Giorgio <michele.digiorgio@arm.com> | 2020-07-29 08:45:19 +0000 |
| commit | 42e57362933b7fa04f9a86297fa75ed38c5e3c97 (patch) | |
| tree | 080cbc776704e2d28ce1029e3864aeecd9f923fd | |
| parent | 1009e87127e08a58561373c3f83f22b5f0922641 (diff) | |
| download | ComputeLibrary-42e57362933b7fa04f9a86297fa75ed38c5e3c97.tar.gz | |
COMPMID-2078: Remove legacy TODOs
Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Change-Id: Ic05ef206f76477cc2fbb9e7ad56ec1974fa013ea
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/3626
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
| -rw-r--r-- | src/core/CL/kernels/CLDirectConvolutionLayerKernel.cpp | 2 | ||||
| -rw-r--r-- | src/runtime/CL/functions/CLGEMMConvolutionLayer.cpp | 1 |
2 files changed, 0 insertions, 3 deletions
diff --git a/src/core/CL/kernels/CLDirectConvolutionLayerKernel.cpp b/src/core/CL/kernels/CLDirectConvolutionLayerKernel.cpp index 4acbe2dff8..d5d808a80f 100644 --- a/src/core/CL/kernels/CLDirectConvolutionLayerKernel.cpp +++ b/src/core/CL/kernels/CLDirectConvolutionLayerKernel.cpp @@ -348,7 +348,6 @@ std::pair<Status, Window> validate_and_configure_window(ITensorInfo *input, ITen TensorShape output_shape = misc::shape_calculator::compute_deep_convolution_shape(*input, *weights, conv_info); // Output auto inizialitation if not yet initialized - // TODO(COMPMID-2078): input->clone()->set_tensor_shape(output_shape) doesn't work with subtensors for grouped direct convolutions (AlexNet). auto_init_if_empty(*output, output_shape, 1, input->data_type(), @@ -433,7 +432,6 @@ void CLDirectConvolutionLayerKernel::configure(const CLCompileContext &compile_c TensorShape output_shape = misc::shape_calculator::compute_deep_convolution_shape(*input->info(), *weights->info(), conv_info); // Output auto inizialitation if not yet initialized - // TODO(COMPMID-2078): input->clone()->set_tensor_shape(output_shape) doesn't work with subtensors for grouped direct convolutions (AlexNet). auto_init_if_empty(*output->info(), output_shape, 1, diff --git a/src/runtime/CL/functions/CLGEMMConvolutionLayer.cpp b/src/runtime/CL/functions/CLGEMMConvolutionLayer.cpp index a0d8c3beeb..ee90b39c2b 100644 --- a/src/runtime/CL/functions/CLGEMMConvolutionLayer.cpp +++ b/src/runtime/CL/functions/CLGEMMConvolutionLayer.cpp @@ -312,7 +312,6 @@ void CLGEMMConvolutionLayer::configure(const CLCompileContext &compile_context, shape_gemm.set(0, mat_weights_cols); shape_gemm.set(1, conv_w * conv_h); - // TODO(COMPMID-2078): input->clone() doesn't work with subtensors for grouped convolutions. TensorInfo info_gemm(shape_gemm, 1, data_type); info_gemm.set_quantization_info(output->info()->quantization_info()).set_data_layout(input->info()->data_layout()); _gemm_output.allocator()->init(info_gemm); |