diff options
| author | Manuel Bottini <manuel.bottini@arm.com> | 2020-08-11 13:18:29 +0100 |
|---|---|---|
| committer | Manuel Bottini <manuel.bottini@arm.com> | 2020-08-12 11:33:35 +0000 |
| commit | dc12519582d06da9fac9c53300a5ab83a5b26632 (patch) | |
| tree | b88c39009d2c3af3320d73c84f8aeb6d34357845 | |
| parent | 315a20eea78a1861a55ba9fa25e244b702384f01 (diff) | |
| download | ComputeLibrary-dc12519582d06da9fac9c53300a5ab83a5b26632.tar.gz | |
COMPMID-3699: Nightly failure CL DirectConvolution
Tolerance issue
Change-Id: I0246b70b03520b13a6a1bc5a92fb4787d7c0e734
Signed-off-by: Manuel Bottini <manuel.bottini@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/3711
Reviewed-by: SiCong Li <sicong.li@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
| -rw-r--r-- | tests/validation/CL/DirectConvolutionLayer.cpp | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/tests/validation/CL/DirectConvolutionLayer.cpp b/tests/validation/CL/DirectConvolutionLayer.cpp index 767da943f2..090bd22ed9 100644 --- a/tests/validation/CL/DirectConvolutionLayer.cpp +++ b/tests/validation/CL/DirectConvolutionLayer.cpp @@ -43,11 +43,11 @@ namespace validation { namespace { -// COMPMID-517 Investigate the mismatch to see whether it is a real bug -RelativeTolerance<half> tolerance_fp16(half(0.2)); /**< Tolerance for floating point tests */ -RelativeTolerance<float> tolerance_fp32(0.03f); /**< Tolerance for floating point tests */ -constexpr float tolerance_num = 0.07f; /**< Tolerance number */ -constexpr AbsoluteTolerance<uint8_t> tolerance_qasymm8(1); /**< Tolerance for quantized tests */ +RelativeTolerance<half> tolerance_fp16(half(0.2)); /**< Tolerance for floating point tests */ +RelativeTolerance<float> tolerance_fp32(0.05f); /**< Tolerance for floating point tests */ +AbsoluteTolerance<float> tolerance_fp32_abs(0.0003f); /**< Absolute Tolerance for floating point tests */ +constexpr float tolerance_num = 0.07f; /**< Tolerance number */ +constexpr AbsoluteTolerance<uint8_t> tolerance_qasymm8(1); /**< Tolerance for quantized tests */ const auto data_strides = combine(framework::dataset::make("StrideX", 1, 3), framework::dataset::make("StrideY", 1, 3)); const auto data_strides_small = combine(framework::dataset::make("StrideX", 1), framework::dataset::make("StrideY", 1)); @@ -88,8 +88,6 @@ const auto ActivationFunctionsDataset = framework::dataset::make("ActivationInfo TEST_SUITE(CL) TEST_SUITE(DirectConvolutionLayer) -//TODO(COMPMID-415): Configuration tests? - // *INDENT-OFF* // clang-format off DATA_TEST_CASE(Validate, framework::DatasetMode::ALL, zip(zip(zip(zip(zip(zip( @@ -238,7 +236,7 @@ FIXTURE_DATA_TEST_CASE(RunLargeUsecase, CLDirectConvolutionLayerFixture<float>, framework::dataset::make("DataLayout", { DataLayout::NHWC }))) { // Validate output - validate(CLAccessor(_target), _reference, tolerance_fp32); + validate(CLAccessor(_target), _reference, tolerance_fp32, 0.f, tolerance_fp32_abs); } TEST_SUITE_END() // FP32 |