From f2ed1b84caccb05c9e00e18b2cb2d2a2875b43fd Mon Sep 17 00:00:00 2001 From: Teresa Charlin Date: Tue, 24 Nov 2020 15:11:54 +0000 Subject: IVGCVSW-5499 Missing validation for zero stride * Convolution * Depthwise Convolution Signed-off-by: Teresa Charlin Change-Id: I61b356fbffb176e9a05e08d9b6867d082b6712c8 --- src/backends/backendsCommon/WorkloadData.cpp | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'src/backends/backendsCommon') diff --git a/src/backends/backendsCommon/WorkloadData.cpp b/src/backends/backendsCommon/WorkloadData.cpp index 530dc48a74..d795e32e4b 100644 --- a/src/backends/backendsCommon/WorkloadData.cpp +++ b/src/backends/backendsCommon/WorkloadData.cpp @@ -1260,6 +1260,14 @@ void Convolution2dQueueDescriptor::Validate(const WorkloadInfo& workloadInfo) co ValidateBiasTensorQuantization(biasTensorInfo, inputTensorInfo, weightTensorInfo, descriptorName); } + if (m_Parameters.m_StrideX <= 0 || m_Parameters.m_StrideY <= 0 ) + { + throw InvalidArgumentException( + fmt::format("{}: strideX (provided {}) and strideY (provided {}) " + "cannot be either negative or 0.", + descriptorName, m_Parameters.m_StrideX, m_Parameters.m_StrideY)); + } + ValidatePerAxisQuantization(inputTensorInfo, outputTensorInfo, weightTensorInfo, @@ -1320,6 +1328,14 @@ void DepthwiseConvolution2dQueueDescriptor::Validate(const WorkloadInfo& workloa descriptorName, m_Parameters.m_DilationX, m_Parameters.m_DilationX)); } + if (m_Parameters.m_StrideX <= 0 || m_Parameters.m_StrideY <= 0 ) + { + throw InvalidArgumentException( + fmt::format("{}: strideX (provided {}) and strideY (provided {}) " + "cannot be either negative or 0.", + descriptorName, m_Parameters.m_StrideX, m_Parameters.m_StrideY)); + } + const unsigned int channelIndex = (m_Parameters.m_DataLayout == DataLayout::NCHW) ? 1 : 3; // Expected weight shape: [ M, I, H, W ] - This shape does NOT depend on the data layout -- cgit v1.2.1