From 43ba0dd3ea46d85267914c3b25cb8f9fdd719789 Mon Sep 17 00:00:00 2001 From: Gunes Bayir Date: Tue, 19 Mar 2024 15:31:11 +0000 Subject: Increase MatMul and DilatedConv test Q8 thresholds to 1 Tolerance for quantized tests is better to be 1 due to possible rounding differences between the Acl and reference implementations. Resolves: COMPMID-6929 Change-Id: I6f317631322b702e6a9579593befff65bbf46151 Signed-off-by: Gunes Bayir Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/11319 Reviewed-by: Pablo Marquez Tello Comments-Addressed: Arm Jenkins Benchmark: Arm Jenkins Tested-by: Arm Jenkins --- tests/validation/NEON/DilatedConvolutionLayer.cpp | 4 ++-- tests/validation/NEON/MatMul.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/validation/NEON/DilatedConvolutionLayer.cpp b/tests/validation/NEON/DilatedConvolutionLayer.cpp index 2ede4fac4f..fbfe8b8a7a 100644 --- a/tests/validation/NEON/DilatedConvolutionLayer.cpp +++ b/tests/validation/NEON/DilatedConvolutionLayer.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018-2021, 2023 Arm Limited. + * Copyright (c) 2018-2021, 2023-2024 Arm Limited. * * SPDX-License-Identifier: MIT * @@ -50,7 +50,7 @@ const AbsoluteTolerance abs_tolerance_f16(0.3f); const RelativeTolerance rel_tolerance_f16(half_float::half(0.2f)); /**< Relative tolerance value for comparing reference's output against implementation's output for DataType::F16 */ constexpr float tolerance_num_f16 = 0.07f; /**< Tolerance number for FP16 */ #endif /* __ARM_FEATURE_FP16_VECTOR_ARITHMETIC */ -constexpr AbsoluteTolerance tolerance_qasymm8(0.0); /**< Tolerance value for comparing reference's output against implementation's output for quantized data types */ +constexpr AbsoluteTolerance tolerance_qasymm8(1); /**< Tolerance value for comparing reference's output against implementation's output for quantized data types */ /** CNN data types */ const auto CNNDataTypes = framework::dataset::make("DataType", diff --git a/tests/validation/NEON/MatMul.cpp b/tests/validation/NEON/MatMul.cpp index 5577a9bb98..f91dea1b4f 100644 --- a/tests/validation/NEON/MatMul.cpp +++ b/tests/validation/NEON/MatMul.cpp @@ -48,8 +48,8 @@ TEST_SUITE(MatMul) constexpr AbsoluteTolerance tolerance_fp32(0.001f); /**< Tolerance value for comparing reference's output against implementation's output for FP32 data types */ const AbsoluteTolerance tolerance_fp16(half(0.1f)); #ifdef __aarch64__ -constexpr AbsoluteTolerance tolerance_qasymm8(0); -constexpr AbsoluteTolerance tolerance_qasymm8_signed(0); +constexpr AbsoluteTolerance tolerance_qasymm8(1); +constexpr AbsoluteTolerance tolerance_qasymm8_signed(1); #endif // __aarch64__ // clang-format off -- cgit v1.2.1