diff options
author | Anthony Barbier <anthony.barbier@arm.com> | 2018-08-10 14:10:08 +0100 |
---|---|---|
committer | Anthony Barbier <anthony.barbier@arm.com> | 2018-11-02 16:54:54 +0000 |
commit | 5a65cfd30e571bc5c24e2333e256f2a4b630f8cb (patch) | |
tree | 4c8d09361d5edc6bc0313110491a0a5353c44e09 /arm_compute | |
parent | 8914e32962be3dc8608499e3c0f2f13141493fc4 (diff) | |
download | ComputeLibrary-5a65cfd30e571bc5c24e2333e256f2a4b630f8cb.tar.gz |
COMPMID-1478: Fixed Doxygen comments + minor fixes
- Allow check_bad_style.sh to only run on some of the files
- Pass missing lws_hint() in CLNormalizationLayerKernel
Change-Id: I2cf44f82f7ba6c8dc8d40691aeec7c6c3de385b5
Reviewed-on: https://eu-gerrit-1.euhpc.arm.com/143628
Reviewed-by: Michele DiGiorgio <michele.digiorgio@arm.com>
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Tested-by: Jenkins <bsgcomp@arm.com>
Diffstat (limited to 'arm_compute')
-rw-r--r-- | arm_compute/core/CL/ICLKernel.h | 8 | ||||
-rw-r--r-- | arm_compute/graph/GraphContext.h | 1 | ||||
-rw-r--r-- | arm_compute/graph/backends/CL/CLDeviceBackend.h | 2 | ||||
-rw-r--r-- | arm_compute/graph/frontend/Stream.h | 2 |
4 files changed, 10 insertions, 3 deletions
diff --git a/arm_compute/core/CL/ICLKernel.h b/arm_compute/core/CL/ICLKernel.h index 150dd62a89..f5423584e1 100644 --- a/arm_compute/core/CL/ICLKernel.h +++ b/arm_compute/core/CL/ICLKernel.h @@ -62,13 +62,19 @@ private: return 2 + 2 * dimension_size; } using IKernel::configure; //Prevent children from calling IKernel::configure() directly -public: +protected: + /** Configure the kernel's window and local workgroup size hint. + * + * @param[in] window The maximum window which will be returned by window() + * @param[in] lws_hint (Optional) Local-Workgroup-Size to use. + */ void configure_internal(const Window &window, cl::NDRange lws_hint = CLKernelLibrary::get().default_ndrange()) { _lws_hint = lws_hint; IKernel::configure(window); } +public: /** Constructor */ ICLKernel() : _kernel(nullptr), _target(GPUTarget::MIDGARD), _config_id(arm_compute::default_config_id), _max_workgroup_size(0), _lws_hint() diff --git a/arm_compute/graph/GraphContext.h b/arm_compute/graph/GraphContext.h index ce6f86f611..b77eb1404d 100644 --- a/arm_compute/graph/GraphContext.h +++ b/arm_compute/graph/GraphContext.h @@ -50,6 +50,7 @@ class GraphContext final public: /** Constructor */ GraphContext(); + /** Destructor */ ~GraphContext(); /** Prevent instances of this class from being copied (As this class contains pointers) */ GraphContext(const GraphContext &) = delete; diff --git a/arm_compute/graph/backends/CL/CLDeviceBackend.h b/arm_compute/graph/backends/CL/CLDeviceBackend.h index cc8d55239e..49e7596d58 100644 --- a/arm_compute/graph/backends/CL/CLDeviceBackend.h +++ b/arm_compute/graph/backends/CL/CLDeviceBackend.h @@ -67,7 +67,7 @@ private: int _context_count; /**< Counts how many contexts are currently using the backend */ CLTuner _tuner; /**< CL kernel tuner */ std::unique_ptr<CLBufferAllocator> _allocator; /**< CL buffer affinity allocator */ - std::string _tuner_file; /** Filename to load/store the tuner's values from */ + std::string _tuner_file; /**< Filename to load/store the tuner's values from */ }; } // namespace backends } // namespace graph diff --git a/arm_compute/graph/frontend/Stream.h b/arm_compute/graph/frontend/Stream.h index c8e24eeae2..9d51016178 100644 --- a/arm_compute/graph/frontend/Stream.h +++ b/arm_compute/graph/frontend/Stream.h @@ -75,7 +75,7 @@ public: private: //Important: GraphContext must be declared *before* the GraphManager because the GraphManager - //allocates resources from the context and therefore needs to be destroyed before the context during clean up). + //allocates resources from the context and therefore needs to be destroyed before the context during clean up. GraphContext _ctx; /**< Graph context to use */ GraphManager _manager; /**< Graph manager */ Graph _g; /**< Internal graph representation of the stream */ |